Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15338#discussion_r83349154
  
    --- Diff: sbin/spark-daemon.sh ---
    @@ -122,6 +123,35 @@ if [ "$SPARK_NICENESS" = "" ]; then
         export SPARK_NICENESS=0
     fi
     
    +execute_command() {
    +  local command="$@"
    +  if [ -z ${SPARK_NO_DAEMONIZE+set} ]; then
    +      nohup -- $command >> $log 2>&1 < /dev/null &
    +      newpid="$!"
    +
    +      echo "$newpid" > "$pid"
    +
    +      #Poll for up to 5 seconds for the java process to start
    --- End diff --
    
    Nit: Space after `#`. (I know it was like this before your PR.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to