Github user sethah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15488#discussion_r83451715
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
 ---
    @@ -519,31 +520,35 @@ class LogisticRegressionSuite
     
       test("binary logistic regression with intercept without regularization") 
{
         val trainer1 = (new 
LogisticRegression).setFitIntercept(true).setStandardization(true)
    +      .setWeightCol("weight")
         val trainer2 = (new 
LogisticRegression).setFitIntercept(true).setStandardization(false)
    +      .setWeightCol("weight")
     
         val model1 = trainer1.fit(binaryDataset)
         val model2 = trainer2.fit(binaryDataset)
     
         /*
    -       Using the following R code to load the data and train the model 
using glmnet package.
    -
    -       library("glmnet")
    -       data <- read.csv("path", header=FALSE)
    -       label = factor(data$V1)
    -       features = as.matrix(data.frame(data$V2, data$V3, data$V4, data$V5))
    -       coefficients = coef(glmnet(features,label, family="binomial", alpha 
= 0, lambda = 0))
    -       coefficients
    +      Use the following R code to load the data and train the model using 
glmnet package.
    +      library("glmnet")
    --- End diff --
    
    I pasted every R code snippet into an R shell, so we can be reasonably 
certain of its correctness


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to