Github user vanzin commented on a diff in the pull request:
    --- Diff: 
    @@ -150,6 +161,62 @@ public synchronized void dispose() {
    +   * Negotiate with peer for extended options, such as using AES cipher.
    +   * @param message is message receive from peer which may contains 
communication parameters.
    +   * @param callback is rpc callback.
    +   * @param conf contains transport configuration.
    +   * @return Object which represent the result of negotiate.
    +   */
    +  public Object negotiate(ByteBuffer message, RpcResponseCallback 
callback, TransportConf conf)
    --- End diff --
    Same comments here re: naming and return type.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to