Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15172#discussion_r83513717
  
    --- Diff: 
common/network-common/src/main/java/org/apache/spark/network/sasl/SaslRpcHandler.java
 ---
    @@ -71,56 +75,78 @@
         this.secretKeyHolder = secretKeyHolder;
         this.saslServer = null;
         this.isComplete = false;
    +    this.isAuthenticated = false;
       }
     
       @Override
       public void receive(TransportClient client, ByteBuffer message, 
RpcResponseCallback callback) {
    +    boolean encrypt = conf.saslServerAlwaysEncrypt();
    --- End diff --
    
    nit: move this later closer to where it's used; avoids the method call when 
not necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to