Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15500#discussion_r83777528
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
 ---
    @@ -77,9 +77,40 @@ case class ProjectExec(projectList: 
Seq[NamedExpression], child: SparkPlan)
         }
       }
     
    -  override def outputOrdering: Seq[SortOrder] = child.outputOrdering
    +  override def outputOrdering: Seq[SortOrder] =
    +    ProjectHelper.outputOrdering(projectList, child.outputOrdering, child)
     }
     
    +object ProjectHelper {
    +  /**
    +   * Determins the outputOrdering property for [[ProjectExec]] and 
[[TakeOrderedAndProjectExec]]
    --- End diff --
    
    yea, it doesn't make sense, but does it cause any problems? I checked the 
code in `EnsureRequirements`, looks like it's ok to have some useless sort 
orders.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to