Github user tejasapatil commented on a diff in the pull request:
    --- Diff: 
    @@ -124,7 +124,14 @@ case class SortArray(base: Expression, ascendingOrder: 
       override def checkInputDataTypes(): TypeCheckResult = base.dataType 
match {
         case ArrayType(dt, _) if RowOrdering.isOrderable(dt) =>
    -      TypeCheckResult.TypeCheckSuccess
    +      ascendingOrder match {
    +        case Literal(_: Boolean, BooleanType) =>
    +          TypeCheckResult.TypeCheckSuccess
    +        case _ =>
    +          TypeCheckResult.TypeCheckFailure(
    +            s"Sort order in second argument requires 
${BooleanType.simpleString} type, however," +
    --- End diff --
    Can you explicitly mention that the error is in context of `sort_array()` ? 
For SQL query which spans 100+ lines, its easy to get lost while tracking why 
it failed. Having better error messages would make that easier for users.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to