Github user kapilsingh5050 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15620#discussion_r90409976
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/conditionalExpressions.scala
 ---
    @@ -64,19 +64,74 @@ case class If(predicate: Expression, trueValue: 
Expression, falseValue: Expressi
         val trueEval = trueValue.genCode(ctx)
         val falseEval = falseValue.genCode(ctx)
     
    -    ev.copy(code = s"""
    -      ${condEval.code}
    -      boolean ${ev.isNull} = false;
    -      ${ctx.javaType(dataType)} ${ev.value} = 
${ctx.defaultValue(dataType)};
    -      if (!${condEval.isNull} && ${condEval.value}) {
    -        ${trueEval.code}
    -        ${ev.isNull} = ${trueEval.isNull};
    -        ${ev.value} = ${trueEval.value};
    -      } else {
    -        ${falseEval.code}
    -        ${ev.isNull} = ${falseEval.isNull};
    -        ${ev.value} = ${falseEval.value};
    -      }""")
    +    // place generated code of condition, true value and false value in 
separate methods if
    +    // their code combined is large
    +    val combinedLength = condEval.code.length + trueEval.code.length + 
falseEval.code.length
    +    val generatedCode = if (combinedLength > 1024 &&
    +      // Split these expressions only if they are created from a row object
    +      (ctx.INPUT_ROW != null && ctx.currentVars == null)) {
    +
    +      val (condFuncName, condGlobalIsNull, condGlobalValue) =
    +        createAndAddFunction(ctx, condEval, predicate.dataType, 
"evalIfCondExpr")
    +      val (trueFuncName, trueGlobalIsNull, trueGlobalValue) =
    +        createAndAddFunction(ctx, trueEval, trueValue.dataType, 
"evalIfTrueExpr")
    +      val (falseFuncName, falseGlobalIsNull, falseGlobalValue) =
    +        createAndAddFunction(ctx, falseEval, falseValue.dataType, 
"evalIfFalseExpr")
    +      s"""
    +        $condFuncName(${ctx.INPUT_ROW});
    +        boolean ${ev.isNull} = false;
    +        ${ctx.javaType(dataType)} ${ev.value} = 
${ctx.defaultValue(dataType)};
    +        if (!$condGlobalIsNull && $condGlobalValue) {
    +          $trueFuncName(${ctx.INPUT_ROW});
    +          ${ev.isNull} = $trueGlobalIsNull;
    +          ${ev.value} = $trueGlobalValue;
    +        } else {
    +          $falseFuncName(${ctx.INPUT_ROW});
    +          ${ev.isNull} = $falseGlobalIsNull;
    +          ${ev.value} = $falseGlobalValue;
    +        }
    +      """
    +    }
    +    else {
    +      s"""
    +        ${condEval.code}
    +        boolean ${ev.isNull} = false;
    +        ${ctx.javaType(dataType)} ${ev.value} = 
${ctx.defaultValue(dataType)};
    +        if (!${condEval.isNull} && ${condEval.value}) {
    +          ${trueEval.code}
    +          ${ev.isNull} = ${trueEval.isNull};
    +          ${ev.value} = ${trueEval.value};
    +        } else {
    +          ${falseEval.code}
    +          ${ev.isNull} = ${falseEval.isNull};
    +          ${ev.value} = ${falseEval.value};
    +        }
    +      """
    +    }
    +
    +    ev.copy(code = generatedCode)
    +  }
    +
    +  private def createAndAddFunction(ctx: CodegenContext,
    --- End diff --
    
    apologies, I'll fix it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to