Github user NathanHowell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16089#discussion_r90503024
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/CodecStreams.scala
 ---
    @@ -0,0 +1,74 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.datasources
    +
    +import java.io.{OutputStream, OutputStreamWriter}
    +import java.nio.charset.{Charset, StandardCharsets}
    +
    +import org.apache.hadoop.fs.Path
    +import org.apache.hadoop.io.compress._
    +import org.apache.hadoop.mapreduce.JobContext
    +import org.apache.hadoop.mapreduce.lib.output.FileOutputFormat
    +import org.apache.hadoop.util.ReflectionUtils
    +
    +object CodecStreams {
    +  private def getCompressionCodec(
    +      context: JobContext,
    +      file: Option[Path] = None): Option[CompressionCodec] = {
    +    if (FileOutputFormat.getCompressOutput(context)) {
    +      val compressorClass = FileOutputFormat.getOutputCompressorClass(
    +        context,
    +        classOf[GzipCodec])
    +
    +      Some(ReflectionUtils.newInstance(compressorClass, 
context.getConfiguration))
    +    } else {
    +      file.flatMap { path =>
    +        val compressionCodecs = new 
CompressionCodecFactory(context.getConfiguration)
    +        Option(compressionCodecs.getCodec(path))
    +      }
    +    }
    +  }
    +
    +  /**
    +   * Create a new file and open it for writing.
    +   * If compression is enabled in the [[JobContext]] the stream will write 
compressed data to disk.
    +   * An exception will be thrown if the file already exists.
    --- End diff --
    
    Is this a problem with Hadoop in general? The FileSystem docs also specify 
this behavior:
    
    ```
      /**
       * Create an FSDataOutputStream at the indicated Path.
       * @param f the file to create
       * @param overwrite if a file with this name already exists, then if true,
       *   the file will be overwritten, and if false an exception will be 
thrown.
       */
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to