Github user jkbradley commented on the issue:

    https://github.com/apache/spark/pull/15795
  
    +1 for consolidating the examples.  The boilerplate of creating a dataset 
and setting algorithm parameters takes up most of the example.  I would create 
1 example per algorithm which does transform, approxNearestNeighbor, and 
approxSimilarityJoin.  The only reason not to would be if those demos required 
different datasets or algorithm settings, but I suspect they could be done in a 
unified manner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to