Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15863#discussion_r90584902
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
 ---
    @@ -41,10 +41,16 @@ class JDBCOptions(
           JDBCOptions.JDBC_TABLE_NAME -> table)))
       }
     
    +  val asProperties: Properties = {
    +    val properties = new Properties()
    +    parameters.foreach { case (k, v) => properties.setProperty(k, v) }
    +    properties
    +  }
    +
       val asConnectionProperties: Properties = {
    --- End diff --
    
    let's add some document to explain when we should use 
`asConnectionProperties` and when `asProperties`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to