Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15620#discussion_r90592789
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
 ---
    @@ -97,6 +97,38 @@ class CodeGenerationSuite extends SparkFunSuite with 
ExpressionEvalHelper {
         assert(actual(0) == cases)
       }
     
    +  test("SPARK-18091: split large if expressions into blocks due to JVM 
code size limit") {
    +    val row = 
create_row("afafFAFFsqcategory2dadDADcategory8sasasadscategory24", 0)
    --- End diff --
    
    > Since the fix in this pull request is only in If expression, a working 
testcase with the fix will be one which consists (recursively) of If 
expressions.
    
    I can't see why this is reasonable. You just need to construct enough big 
generated codes of condition + true expression + false expression.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to