Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16512#discussion_r96032164
  
    --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
    @@ -196,6 +196,12 @@ test_that("create DataFrame from RDD", {
       expect_equal(dtypes(df), list(c("name", "string"), c("age", "int"), 
c("height", "float")))
       expect_equal(as.list(collect(where(df, df$name == "John"))),
                    list(name = "John", age = 19L, height = 176.5))
    +  expect_equal(getNumPartitions(toRDD(df)), 1)
    --- End diff --
    
    Thanks so much for digging into this ! I kind of like the behavior of 
`positions` (distributing things evenly etc.) and also the fact that we will be 
maintaining similar behavior as scala with this new function.  And the `lapply` 
code fragment is not that much more complex imho in terms of readability
    
    So my take is lets go for it ? We can also add a comment saying we are 
mimicing positions in case somebody wonders why we didn't use a one-liner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to