Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18224#discussion_r121253322
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/util/FileBasedWriteAheadLog.scala
---
@@ -205,10 +205,12 @@ private[streaming] class FileBasedWriteAheadLog(
/** Stop the manager, close any open log writer */
def close(): Unit = synchronized {
- if (currentLogWriter != null) {
- currentLogWriter.close()
+ if (!executionContext.isShutdown) {
--- End diff --
@srowen, maybe I missed your point. However, wouldn't there be a change to
try `shutdown` multiple times if `isShutdown` is not synchronised together?
Probably, `shutdown` is idempotent itself but just wonder if it is okay to keep
this as a safeguard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
