Github user lubozhan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18347#discussion_r122639236
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
    @@ -465,6 +465,8 @@ case class DataSource(
         providingClass.newInstance() match {
           case dataSource: CreatableRelationProvider =>
             SaveIntoDataSourceCommand(data, dataSource, 
caseInsensitiveOptions, mode)
    +      case dataSource: ConsoleSinkProvider =>
    +        data.show(data.count().toInt, false)
    --- End diff --
    
    Sorry for late reply.
    Yes, it is right to use underscore since dataSource is not used. 
Considering it is no need to create a new ConsoleSink and no access to the 
private variable, i will use caseInsensitiveOptions instead to extract the 
numRows and truncate, 
    Thanks for your comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to