Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18320#discussion_r122639738
  
    --- Diff: R/pkg/inst/worker/daemon.R ---
    @@ -31,7 +31,15 @@ inputCon <- socketConnection(
         port = port, open = "rb", blocking = TRUE, timeout = connectionTimeout)
     
     while (TRUE) {
    -  ready <- socketSelect(list(inputCon))
    +  ready <- socketSelect(list(inputCon), timeout = 1)
    +
    +  # Terminate R workers in the parent process.
    +  finishedChildren <- parallel:::selectChildren()
    --- End diff --
    
    Definitely for comments.
    
    Maybe I missed your point. Children will only return their PID on exit and 
`parallel:::selectChildren()` will only return children PIDs that finished they 
work and called `parallel:::mcexit(0L)` (related test was done 
https://github.com/apache/spark/pull/18320#discussion_r122605437) up to my 
knowledge. So, even if connecting to JVM is delayed in `worker.R` and 
`RRunner.scala`, it won't matter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to