Github user zero323 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17922#discussion_r123766355
--- Diff: python/pyspark/ml/tests.py ---
@@ -832,6 +860,96 @@ def test_logistic_regression(self):
except OSError:
pass
+ def logistic_regression_check_thresholds(self):
+ self.assertIsInstance(
+ LogisticRegression(threshold=0.5, thresholds=[0.5, 0.5]),
+ LogisticRegressionModel
+ )
+
+ self.assertRaisesRegexp(
+ ValueError,
+ "Logistic Regression getThreshold found inconsistent.*$",
+ LogisticRegression, threshold=0.42, thresholds=[0.5, 0.5]
+ )
+
+ def test_binomial_logistic_regression_bounds(self):
--- End diff --
Example datasets are not that good for checking constraints, and generator
seems like a better idea than creating large enough example by hand. I can of
course remove it, if this is an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
