GitHub user vinodkc opened a pull request:

    https://github.com/apache/spark/pull/18852

    [SPARK-21588][SQL] SQLContext.getConf(key, null) should return null

    ## What changes were proposed in this pull request?
    
    In SQLContext.get(key,null) for a key that is not defined in the conf, and 
doesn't have a default value defined, throws a NPE. In happens only when conf 
has a value converter
    
    Added null check on defaultValue inside SQLConf.getConfString to avoid 
calling entry.valueConverter(defaultValue) 
    
    ## How was this patch tested?
    Added unit test

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vinodkc/spark br_Fix_SPARK-21588

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18852.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18852
    
----
commit 53b73ed21a028ea1915df8a9a03d6d9368e53c8a
Author: vinodkc <vinod.kc...@gmail.com>
Date:   2017-08-05T06:39:04Z

    SQLContext.getConf(key, null) should return null

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to