Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18769#discussion_r131535400
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/SetCommand.scala 
---
    @@ -88,12 +88,13 @@ case class SetCommand(kv: Option[(String, 
Option[String])]) extends RunnableComm
         // Configures a single property.
         case Some((key, Some(value))) =>
           val runFunc = (sparkSession: SparkSession) => {
    -        if 
(sparkSession.conf.get(CATALOG_IMPLEMENTATION.key).equals("hive")
    -          && key.startsWith("hive.")) {
    -          logWarning(s"SET $key=$value doesn't work, " +
    -            s"because Spark doesn't support set hive config dynamically. " 
+
    -            s"Please set hive config through " +
    -            s"--conf spark.hadoop.$key=$value before SparkSession is 
initialized.")
    +        if 
(sparkSession.conf.get(CATALOG_IMPLEMENTATION.key).equals("hive") &&
    +          key.startsWith("hive.")) {
    +          logWarning(s"'SET $key=$value' might not work, since Spark 
doesn't support changing " +
    +            s"the Hive config dynamically. Please passing the 
Hive-specific config by adding the " +
    +            s"prefix spark.hadoop (e.g.,spark.hadoop.$key) when starting a 
Spark application. " +
    +            s"For details, see the link: 
https://spark.apache.org/docs/latest/configuration.html#"; +
    +            s"dynamically-loading-spark-properties.")
    --- End diff --
    
    Except the line 93, the other lines do not need `s`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to