Github user viirya commented on a diff in the pull request:
    --- Diff: 
    @@ -403,11 +403,13 @@ class MathExpressionsSuite extends SparkFunSuite with 
ExpressionEvalHelper {
       test("sqrt") {
         testUnary(Sqrt, math.sqrt, (0 to 20).map(_ * 0.1))
    -    testUnary(Sqrt, math.sqrt, (-5 to -1).map(_ * 1.0), expectNaN = true)
    +    testUnary(Sqrt, math.sqrt, (-5 to -1).map(_ * 1.0), expectNull = true)
    --- End diff --
    Looks like you're changing the NaN cases for many math expressions to Null. 
I'm not sure if we can do thing like this to break compatibility.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to