Github user eatoncys commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18810#discussion_r131593593
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
 ---
    @@ -370,6 +370,12 @@ case class WholeStageCodegenExec(child: SparkPlan) 
extends UnaryExecNode with Co
     
       override def doExecute(): RDD[InternalRow] = {
         val (ctx, cleanedSource) = doCodeGen()
    +    val existLongFunction = ctx.existTooLongFunction
    +    if (existLongFunction) {
    +      logWarning(s"Function is too long, Whole-stage codegen disabled for 
this plan:\n "
    +        + s"$treeString")
    --- End diff --
    
    @gatorsmile , thank you for review, the treeString not contains the code, 
it only contains the tree string of the Physical plan like below:
    *HashAggregate(keys=[k1#2395L, k2#2396, k3#2397], 
functions=[partial_sum(id#2392L)...
    +- *Project [id#2392L, (id#2392L & 1023) AS k1#2395L, cast((id#2392L & 
1023) as double) AS k2#2396...
    +- *Range (0, 655360, step=1, splits=1)
    So, I think it will not be very big.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to