Github user srowen commented on a diff in the pull request:
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -207,9 +207,16 @@ private[deploy] class SparkSubmitArguments(args: 
Seq[String], env: Map[String, S
           uriScheme match {
             case "file" =>
               try {
    -            val jar = new JarFile(uri.getPath)
    -            // Note that this might still return null if no main-class is 
set; we catch that later
    -            mainClass = 
    +            var jar: JarFile = null
    +            Utils.tryWithSafeFinally {
    --- End diff --
    Ah pardon, I meant `Utils.tryWithResource`. This one doesn't help close the 
resource. I don't know which one is actually clearer; up to you.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to