GitHub user tdas opened a pull request:

    https://github.com/apache/spark/pull/18890

    [SPARK-21596][SS] Ensure places calling HDFSMetadataLog.get check the 
return value

    When I was investigating a flaky test, I realized that many places don't 
check the return value of `HDFSMetadataLog.get(batchId: Long): Option[T]`. When 
a batch is supposed to be there, the caller just ignores None rather than 
throwing an error. If some bug causes a query doesn't generate a batch metadata 
file, this behavior will hide it and allow the query continuing to run and 
finally delete metadata logs and make it hard to debug.
    
    This PR ensures that places calling HDFSMetadataLog.get always check the 
return value.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tdas/spark SPARK-21596-2.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18890
    
----
commit 532529a485fb884579c13271a43d39167b7fbf16
Author: Shixiong Zhu <shixi...@databricks.com>
Date:   2017-08-09T03:20:26Z

    [SPARK-21596][SS] Ensure places calling HDFSMetadataLog.get check the 
return value
    
    When I was investigating a flaky test, I realized that many places don't 
check the return value of `HDFSMetadataLog.get(batchId: Long): Option[T]`. When 
a batch is supposed to be there, the caller just ignores None rather than 
throwing an error. If some bug causes a query doesn't generate a batch metadata 
file, this behavior will hide it and allow the query continuing to run and 
finally delete metadata logs and make it hard to debug.
    
    This PR ensures that places calling HDFSMetadataLog.get always check the 
return value.
    
    Jenkins
    
    Author: Shixiong Zhu <shixi...@databricks.com>
    
    Closes #18799 from zsxwing/SPARK-21596.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to