Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18879#discussion_r132123263
  
    --- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
 ---
    @@ -35,7 +35,7 @@ private[hive] object SparkSQLEnv extends Logging {
       def init() {
         if (sqlContext == null) {
           val sparkConf = new SparkConf(loadDefaults = true)
    -      // If user doesn't specify the appName, we want to get 
[SparkSQL::localHostName] instead of
    +      // If user doesn't specify the appName, we will get [SparkSQL::IP] 
instead of
    --- End diff --
    
    What is SparkSQL::IP?
    I think this is not worth a JIRA / PR relative to the time spent looking at 
it
    What problem does this cause a user?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to