Github user adrian-ionescu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18884#discussion_r132147389
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
 ---
    @@ -269,50 +278,57 @@ object FileFormatWriter extends Logging {
       }
     
       /**
    +   * For every registered [[WriteJobStatsTracker]], call `processStats()` 
on it, passing it
    +   * the corresponding [[WriteTaskStats]] from all executors.
    +   */
    +  private def processStats(
    +      statsTrackers: Seq[WriteJobStatsTracker],
    +      statsPerTask: Seq[Seq[WriteTaskStats]])
    --- End diff --
    
    Not sure if that's a common use case..
    But if you do need to share some stats in two trackers, I can think of two 
solutions within the current framework:
    1. in the `processStats` of the first tracker store the somewhere (e.g. 
catalog) and then retrieve them during `processStats` of the second tracker
    2. replace the two trackers with a single, combined one (inheritance / 
composition)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to