Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18884#discussion_r132183030
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSink.scala
 ---
    @@ -128,6 +128,7 @@ class FileStreamSink(
             hadoopConf = hadoopConf,
             partitionColumns = partitionColumns,
             bucketSpec = None,
    +        statsTrackers = Nil,
    --- End diff --
    
    I think `FileStreamSink` is not a `RunnableCommand`? #18159 adds data 
writing metrics for certain `RunnableCommand`.
    
    Do we have a physical node representing data writing operation in a 
`FileStreamSink` so we can bind its `SQLMetric` and update the metrics after 
insertion? Looks like the `addBatch` accepts arbitrary `DataFrame` and writes 
the data from it directly.
    
    I'd think it might be another issue.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to