Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18884#discussion_r132440680
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
 ---
    @@ -269,50 +278,57 @@ object FileFormatWriter extends Logging {
       }
     
       /**
    +   * For every registered [[WriteJobStatsTracker]], call `processStats()` 
on it, passing it
    +   * the corresponding [[WriteTaskStats]] from all executors.
    +   */
    +  private def processStats(
    +      statsTrackers: Seq[WriteJobStatsTracker],
    +      statsPerTask: Seq[Seq[WriteTaskStats]])
    --- End diff --
    
    If 2 trackers have overlapped metrics, I think we probably need to combine 
them into one (inheritance / composition).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to