GitHub user coyotehills opened a pull request:

    https://github.com/apache/spark/pull/18908

    [SPARK-21644][SQL] fix LocalLimit.maxRows

    ## What changes were proposed in this pull request?
    
    Since `LocalLimit` is only about partition level limits, the max output 
rows should be larger than or equal to this limit. On the other hand, we can 
not get the partition information from the child logic plan, so we can only 
assume its max output rows equals to the child's max output rows (In practice, 
this might overestimate the row sizes).
    
    cc: @rxin @gatorsmile  
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration 
tests, manual tests)
    (If this patch involves UI changes, please attach a screenshot; otherwise, 
remove this)
    
    Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/coyotehills/spark fix_limit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18908.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18908
    
----
commit 2f3356f94354eef02ec410ec053f2da26691d1d0
Author: Feng Liu <feng...@databricks.com>
Date:   2017-08-10T17:01:40Z

    some

commit d60f9d38cfe33101883615851d807c4bc6b1af49
Author: Feng Liu <feng...@databricks.com>
Date:   2017-08-10T17:03:22Z

    init

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to