Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18899#discussion_r132561864
  
    --- Diff: project/MimaExcludes.scala ---
    @@ -1012,6 +1012,10 @@ object MimaExcludes {
           
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.classification.RandomForestClassificationModel.setFeatureSubsetStrategy"),
           
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.regression.RandomForestRegressionModel.numTrees"),
           
ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.ml.regression.RandomForestRegressionModel.setFeatureSubsetStrategy")
    +    ) ++ Seq(
    +      // [SPARK-21680][ML][MLLIB]optimzie Vector coompress
    --- End diff --
    
    Hm, does this really cause a MiMa failure? what's the message, is it about 
adding the new method to the interface? I think it could be OK because it's a 
sealed trait that user code can't implement. CC maybe @MLnick or @sethah or 
@jkbradley for a thought on that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to