Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r140047573
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -66,6 +66,12 @@ class TaskInfo(
*/
var finishTime: Long = 0
+ /**
+ * Set this tag when this task killed by other attempt. This kind of
task should not resubmit
+ * while executor lost.
+ */
--- End diff --
nit: calling it a "tag" doesn't aid understanding, but rather leaves me
wondering why it was called a "tag" instead of a "var" or something more
descriptive.
more consequential: Please explain what defines "this kind" of task.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
