Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19799#discussion_r152788814
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -862,17 +859,17 @@ class VersionsSuite extends SparkFunSuite with
Logging {
| "logicalType": "decimal"
| }
| ]
- | } ]
+ | }]
|}
""".stripMargin
- val schemaUrl = s"""$schemaPath${File.separator}avroDecimal.avsc"""
- val schemaFile = new File(schemaPath, "avroDecimal.avsc")
+ val schemaFile = new File(dir, "avroDecimal.avsc")
val writer = new PrintWriter(schemaFile)
writer.write(avroSchema)
writer.close()
+ val schemaPath = schemaFile.getCanonicalPath
--- End diff --
Ah, just for the test on Windows. Windows paths are like `C:\a\b\c` does
not look going though the parser as is. It looks requiring escaping it ..
Probably the easiest way is using URI to easily make the tests pass on Windows
and Linux.
I have fixed those tests to pass on Windows few times. Up to my knowledge,
there is a weak promise that Spark can run on Windows -
https://spark.apache.org/docs/latest/#downloading. IMHO, it might be a bit
better to use URI always when we remember this, and if those tests are not
specific to path forms ..
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
