Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20341#discussion_r162812178
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDAFSuite.scala
---
@@ -49,8 +49,12 @@ class HiveUDAFSuite extends QueryTest with
TestHiveSingleton with SQLTestUtils {
}
protected override def afterAll(): Unit = {
- sql(s"DROP TEMPORARY FUNCTION IF EXISTS mock")
- sql(s"DROP TEMPORARY FUNCTION IF EXISTS hive_max")
+ try {
+ sql(s"DROP TEMPORARY FUNCTION IF EXISTS mock")
+ sql(s"DROP TEMPORARY FUNCTION IF EXISTS hive_max")
--- End diff --
Actually, these drop functions are unnecessary. However, it sounds also
fine to keep them because we should clean up the local objects after usage.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
