Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20464#discussion_r165582806
  
    --- Diff: R/pkg/R/column.R ---
    @@ -169,7 +169,7 @@ setMethod("alias",
     #' @note substr since 1.4.0
     setMethod("substr", signature(x = "Column"),
               function(x, start, stop) {
    -            jc <- callJMethod(x@jc, "substr", as.integer(start - 1), 
as.integer(stop - start + 1))
    +            jc <- callJMethod(x@jc, "substr", as.integer(start), 
as.integer(stop - start + 1))
    --- End diff --
    
    > * why consider other changes as a follow up and not here? [#20464 
(comment)](https://github.com/apache/spark/pull/20464#issuecomment-362162014)
    
    Just because I think it is another issue regarding 0/negative indices. I 
can deal it here if you strongly feel it is better.
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to