Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20499#discussion_r165883051
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -1557,6 +1557,9 @@ def replace(self, to_replace, value=None, 
subset=None):
                 For example, if `value` is a string, and subset contains a 
non-string column,
                 then the non-string column is simply ignored.
     
    +        .. note:: `value` can only be omitted when `to_replace` is a 
dictionary. Otherwise,
    +            it is required.
    --- End diff --
    
    Shall we just describe this in `value`'s param doc?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to