Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20499#discussion_r165883566
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -2186,7 +2186,7 @@ def test_replace(self):
             # replace with subset specified with one column replaced, another 
column not in subset
             # stays unchanged.
             row = self.spark.createDataFrame(
    -            [(u'Alice', 10, 10.0)], schema).replace(10, 20, 
subset=['name', 'age']).first()
    +            [(u'Alice', 10, 10.0)], schema).replace(10, value=20, 
subset=['name', 'age']).first()
    --- End diff --
    
    Are the above two test changes necessary?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to