Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20490#discussion_r166898992
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataWriterFactory.java
 ---
    @@ -32,6 +32,16 @@
     @InterfaceStability.Evolving
     public interface DataWriterFactory<T> extends Serializable {
     
    +  /**
    +   * Returns whether Spark should use the OutputCommitCoordinator to 
ensure that only one attempt
    +   * for each task commits.
    +   *
    +   * @return true if commit coordinator should be used, false otherwise.
    +   */
    +  default boolean useCommitCoordinator() {
    --- End diff --
    
    it's weird to put this method in `DataWriterFactory`, as it's not related 
to factory. How about we put it in `DataSourceWriter`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to