Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20490#discussion_r167306077
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceWriter.java
 ---
    @@ -62,6 +62,16 @@
        */
       DataWriterFactory<Row> createWriterFactory();
     
    +  /**
    +   * Returns whether Spark should use the commit coordinator to ensure 
that only one attempt for
    --- End diff --
    
    `only one` -> `at most one`? BTW I think we should not link to an internal 
class.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to