Github user a10y commented on the issue:

    https://github.com/apache/spark/pull/20580
  
    If you did add a test it should probably generate the Parquet file 
programmatically rather than checking it in. Some examples in 
https://github.com/apache/spark/blob/master/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetInteroperabilitySuite.scala.
    
    However, given that there weren't tests before and this just fixes a break 
that was recently introduced, it seems reasonable that creation of tests for 
the vectorized reader can be done in a folowup?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to