Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20580#discussion_r167656976
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
 ---
    @@ -444,7 +444,8 @@ private void readBinaryBatch(int rowId, int num, 
WritableColumnVector column) {
         // This is where we implement support for the valid type conversions.
         // TODO: implement remaining type conversions
         VectorizedValuesReader data = (VectorizedValuesReader) dataColumn;
    -    if (column.dataType() == DataTypes.StringType || column.dataType() == 
DataTypes.BinaryType) {
    +    if (column.dataType() == DataTypes.StringType || column.dataType() == 
DataTypes.BinaryType
    +            || DecimalType.isByteArrayDecimalType(column.dataType())) {
    --- End diff --
    
    Also please correct the indent too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to