Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20590#discussion_r167700392
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
---
@@ -188,6 +188,9 @@ class OrcFileFormat
if (enableVectorizedReader) {
val batchReader = new OrcColumnarBatchReader(
enableOffHeapColumnVector && taskContext.isDefined,
copyToSpark, capacity)
+ val iter = new RecordReaderIterator(batchReader)
+ Option(TaskContext.get()).foreach(_.addTaskCompletionListener(_
=> iter.close()))
+
batchReader.initialize(fileSplit, taskAttemptContext)
--- End diff --
@cloud-fan and @gatorsmile . Could you take a look this?
For ORC library, it looks okay when we call `close` correctly.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
