Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20548#discussion_r167761351
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala ---
    @@ -298,22 +298,24 @@ object DataType {
        * Returns true if the two data types share the same "shape", i.e. the 
types (including
        * nullability) are the same, but the field names don't need to be the 
same.
        */
    -  def equalsStructurally(from: DataType, to: DataType): Boolean = {
    +  def equalsStructurally(from: DataType, to: DataType,
    +      ignoreNullability: Boolean = false): Boolean = {
    --- End diff --
    
    Nit: the indents.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to