Github user cloud-fan commented on a diff in the pull request:
    --- Diff: 
    @@ -160,6 +162,25 @@ abstract class OrcSuite extends OrcTest with 
BeforeAndAfterAll {
    +  // This should be tested manually because it raises OOM intentionally
    +  // in order to cause `Leaked filesystem connection`. The test suite 
dies, too.
    --- End diff --
    ah, nice trick to fail the reader midway!
    But it's a little weird to have it as a unit test, shall we just put it in 
the PR description and say it's manually tested? This test needs to be run 
manually anyway...


To unsubscribe, e-mail:
For additional commands, e-mail:

Reply via email to