Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20590#discussion_r167828374
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -160,6 +162,25 @@ abstract class OrcSuite extends OrcTest with
BeforeAndAfterAll {
}
}
}
+
+ // This should be tested manually because it raises OOM intentionally
+ // in order to cause `Leaked filesystem connection`. The test suite
dies, too.
--- End diff --
ah, nice trick to fail the reader midway!
But it's a little weird to have it as a unit test, shall we just put it in
the PR description and say it's manually tested? This test needs to be run
manually anyway...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
