Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20590#discussion_r167904770
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
 ---
    @@ -188,6 +188,9 @@ class OrcFileFormat
             if (enableVectorizedReader) {
               val batchReader = new OrcColumnarBatchReader(
                 enableOffHeapColumnVector && taskContext.isDefined, 
copyToSpark, capacity)
    +          val iter = new RecordReaderIterator(batchReader)
    +          Option(TaskContext.get()).foreach(_.addTaskCompletionListener(_ 
=> iter.close()))
    --- End diff --
    
    Could you please add comment why we put this registration here with 
`SPARK-23399`. Since we would forget this investigation in the future :), this 
comment will help us and will remind to run the test case manually.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to