Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20610#discussion_r168322506
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala ---
    @@ -20,14 +20,26 @@ package org.apache.spark.sql
     import java.io.FileNotFoundException
     
     import org.apache.hadoop.fs.Path
    +import org.scalatest.BeforeAndAfterAll
     
     import org.apache.spark.SparkException
     import org.apache.spark.sql.internal.SQLConf
     import org.apache.spark.sql.test.SharedSQLContext
     
    -class FileBasedDataSourceSuite extends QueryTest with SharedSQLContext {
    +
    +class FileBasedDataSourceSuite extends QueryTest with SharedSQLContext 
with BeforeAndAfterAll {
       import testImplicits._
     
    +  override def beforeAll(): Unit = {
    +    super.beforeAll()
    +    spark.sessionState.conf.setConf(SQLConf.ORC_IMPLEMENTATION, "native")
    +  }
    +
    +  override def afterAll(): Unit = {
    +    spark.sessionState.conf.unsetConf(SQLConf.ORC_IMPLEMENTATION)
    +    super.afterAll()
    +  }
    --- End diff --
    
    The test coverage is the same.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to