Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20651#discussion_r169919844
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala 
---
    @@ -172,6 +185,20 @@ private[ui] class AllStagesPage(parent: StagesTab) 
extends WebUIPage("") {
               {completedStagesTable.toNodeSeq}
             </div>
         }
    +    if (shouldShowSkippedStages) {
    +      content ++=
    +        <span id="skipped" class="collapse-aggregated-allSkippedStages 
collapse-table"
    --- End diff --
    
    thanks, I added the UT. I think we can create a new JIRA/followup PR to 
resolve the code redundancy issue you rightly pointed out, what do you think?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to