Github user gaborgsomogyi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20362#discussion_r170074167
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
    @@ -586,6 +586,68 @@ class ALSSuite
           allModelParamSettings, checkModelData)
       }
     
    +  private def checkNumericTypesALS(
    --- End diff --
    
    It's changed because one of the test hasn't done anything. Please take a 
look at the last commit it contains a test bugfix not only the transformation.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to