GitHub user heary-cao opened a pull request:

    https://github.com/apache/spark/pull/20747

    [SPARK-23609][SQL][TEST]Test code does not conform to the test title

    ## What changes were proposed in this pull request?
    
    Currently, In testing EnsureRequirements's test cases to eliminate 
ShuffleExchange, The test code is not in conformity with the purpose of the 
test.These test cases are as follows:
    1、`test("EnsureRequirements eliminates Exchange if child has same 
partitioning")`
       The checking condition is that there is no ShuffleExchange in the 
physical plan. `= = 2` It's not accurate here.
    2、`test("EnsureRequirements does not eliminate Exchange with different 
partitioning")
    `   The purpose of the test is to not eliminate ShuffleExchange, but its 
test code is the same as` test("EnsureRequirements eliminates Exchange if child 
has same partitioning")
    `
    ## How was this patch tested?
    
    the existed test cases.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/heary-cao/spark EnsureRequirementsTest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20747.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20747
    
----
commit 1dd98250c8c2236d52c5ee1c56fbe6c478a4ccbc
Author: caoxuewen <cao.xuewen@...>
Date:   2018-03-06T08:14:25Z

    Test code does not conform to the test title

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to