Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20748#discussion_r172588993
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
 ---
    @@ -133,37 +169,39 @@ trait ExpressionEvalHelper extends 
GeneratorDrivenPropertyChecks {
         }
       }
     
    +  private def evaluateWithoutCodegen(
    --- End diff --
    
    Why not rename the actual method?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to