GitHub user MaxGekk opened a pull request:

    https://github.com/apache/spark/pull/20762

    [SPARK-23620] Splitting thread dump lines by using the br tag

    ## What changes were proposed in this pull request?
    
    I propose to replace `'\n'` by the `<br>` tag in generated html of thread 
dump page. The `<br>` tag will split thread lines in more reliable way. For now 
it could look like on 
    <img width="1265" alt="the screen shot" 
src="https://user-images.githubusercontent.com/1580697/37118202-bcd98fc0-2253-11e8-9e61-c2f946869ee0.png";>
     if the html is proxied and `'\n'` is replaced by another whitespace. The 
changes allow to more easily read and copy stack traces.
    
    ## How was this patch tested?
    
    I tested it manually by checking the thread dump page and its source.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MaxGekk/spark-1 br-thread-dump

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20762.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20762
    
----
commit d1d95c6d351b03f99eb16a70329fe450cd47daca
Author: Maxim Gekk <maxim.gekk@...>
Date:   2018-03-07T20:36:07Z

    Splitting thread dump lines by using the br tag

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to