Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20756#discussion_r173062087
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
 ---
    @@ -111,12 +112,14 @@ trait ExpressionEvalHelper extends 
GeneratorDrivenPropertyChecks {
             val errMsg = intercept[T] {
               eval
             }.getMessage
    -        if (errMsg != expectedErrMsg) {
    +        if (!errMsg.contains(expectedErrMsg)) {
    --- End diff --
    
    For codegen error, it has longer message like:
    
    ```
    Code generation of initializejavabean([], (nonexisting,1)) failed:
    [info]   java.util.concurrent.ExecutionException: 
org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 41, 
Column 22
    : failed to compile: org.codehaus.commons.compiler.CompileException: File 
'generated.java', Line 41, Column 22: A method named "nonexisting
    " is not declared in any enclosing class nor any supertype, nor through a 
static import
    [info]   java.util.concurrent.ExecutionException: 
org.codehaus.commons.compiler.CompileException: File 'generated.java', Line 41, 
Column 22
    : failed to compile: org.codehaus.commons.compiler.CompileException: File 
'generated.java', Line 41, Column 22: A method named "nonexisting
    " is not declared in any enclosing class nor any supertype, nor through a 
static import
    [info]          at 
com.google.common.util.concurrent.AbstractFuture$Sync.getValue(AbstractFuture.java:306)
    [info]          at 
com.google.common.util.concurrent.AbstractFuture$Sync.get(AbstractFuture.java:293)
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to