Github user attilapiros commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20925#discussion_r179814761
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -289,27 +288,26 @@ private[deploy] class SparkSubmitArguments(args: 
Seq[String], env: Map[String, S
         }
    --- End diff --
    
    This might be a good candidate to use your new error method instead of 
throwing the Exception directly. It might happen there is client catching both 
Exception and SparkException and doing very different things but I guess that 
is very unlikely case.   


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to